Skip to content

Conversation

@TQJADE
Copy link
Contributor

@TQJADE TQJADE commented Jul 30, 2025

What changes were proposed in this pull request?

Operator fail to create ingress for spec with driverServiceIngressSpec.

Why are the changes needed?

Modify the role and grant the access

Does this PR introduce any user-facing change?

no

How was this patch tested?

Manually modify the role' s spec and test with sample CR.

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added the BUILD label Jul 30, 2025
@peter-toth
Copy link
Contributor

Hi @TQJADE, can you please elaborate on why this fix needed and fill in the PR description? Is this change related to https://issues.apache.org/jira/browse/SPARK-51347 / #159 where ingress support was added?

cc @jiangzho

@TQJADE
Copy link
Contributor Author

TQJADE commented Aug 4, 2025

Hi @TQJADE, can you please elaborate on why this fix needed and fill in the PR description? Is this change related to https://issues.apache.org/jira/browse/SPARK-51347 / #159 where ingress support was added?

cc @jiangzho

Thanks, updated. @peter-toth

@jiangzho
Copy link
Contributor

jiangzho commented Aug 5, 2025

yes - this is required in order to set permissions to the feature added in #159

@peter-toth peter-toth closed this in 9791943 Aug 5, 2025
@peter-toth
Copy link
Contributor

Thanks @TQJADE!

Merged to main (0.5.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants